Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Linear filter has rounding errors #115

Closed
tpoisot opened this issue Oct 17, 2018 · 2 comments
Closed

Linear filter has rounding errors #115

tpoisot opened this issue Oct 17, 2018 · 2 comments
Labels
bug to do

Comments

@tpoisot
Copy link
Member

tpoisot commented Oct 17, 2018

In some situations (I don't know which exactly) the linearfilter can generate probabilities of 1.0000...1 -- this usually send the whole analysis crashing down.
@MichielStock
Copy link
Contributor

Is solving this by returning max.(min.(F, 1.0), 0.0) in the linear filter an option?

tpoisot added a commit that referenced this issue Nov 7, 2018
@tpoisot
🐛 fix the rounding issues in linearfilter #115
e77b3e4
@tpoisot
Copy link
Member Author

tpoisot commented Nov 7, 2018

Possibly -- I just pushed something with this fix.

@tpoisot tpoisot closed this as completed Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tpoisot @MichielStock