Fix for issue iamdustan#45-- don't try and scroll a position:fixed el…

…ement into view
PointSource · May 6, 2017 · c93b525 · c93b525
1 parent 9da17b4
commit c93b525
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/smoothscroll.js b/src/smoothscroll.js
@@ -287,12 +287,14 @@
           scrollableParent.scrollLeft + clientRects.left - parentRects.left,
           scrollableParent.scrollTop + clientRects.top - parentRects.top
         );
-        // reveal parent in viewport
-        w.scrollBy({
-          left: parentRects.left,
-          top: parentRects.top,
-          behavior: 'smooth'
-        });
+        if (w.getComputedStyle(scrollableParent).position != 'fixed') {
+          // reveal parent in viewport
+          w.scrollBy({
+            left: parentRects.left,
+            top: parentRects.top,
+            behavior: 'smooth'
+          });
+        }
       } else {
         // reveal element in viewport
         w.scrollBy({