-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[common] Warning messages when converting empty PCLPointCloud2 #6092
Comments
Hi, I do not really understand: why, or for what purpose, is it necessary to explicitly indicate no points? Why should the sender not simply omit the message? I think the warning could be helpful for users who made a mistake and forgot to fill in the @larshg What is your opinion on removing the warning? (since it was your commit that added it) |
Hi, thank you for the response. In our case, PointCloud2 data is transferred as ROS message. For example, a obstacle detection ROS node (process) detects points which may collide with the robot, and publish detected points as PointCloud2 ROS message A motion planner ROS node subscribes the detected obstacle points as PointCloud2 ROS message and plan the robot motion. In such robotics case, empty PointCloud2 has proper meaning which is different from no-data. |
Thanks for the explanation, that sounds reasonable. If @larshg is fine with removing the warning then I am as well. |
Sure go ahead. |
Thank you! |
Describe the bug
Since pcl-1.14.0,
pcl::fromPCLPointCloud2()
outputs[pcl::fromPCLPointCloud2] No data to copy.
as warning when handling empty (but having headers)PCLPointCloud2
, and it floods log output.Context
Especially on robotics applications, empty PointCloud2 message is often used to indicate there are no points.
Expected behavior
No log or lower verbosity level log when converting empty PCLPointCloud2.
Current Behavior
[pcl::fromPCLPointCloud2] No data to copy.
is shown as warning.To Reproduce
Running this outputs
Screenshots/Code snippets
This problem is introduced by this commit: 788c53e
pcl/common/include/pcl/conversions.h
Lines 241 to 246 in 2661588
Your Environment (please complete the following information):
Possible Solution
Remove
pcl/common/include/pcl/conversions.h
Line 244 in 2661588
or change it to
PCL_DEBUG
Additional context
The text was updated successfully, but these errors were encountered: