Support for lifetimes in receiver parameters #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bromeon
force-pushed
the
feature/param-lifetimes
branch
2 times, most recently
from
1ae5627 to
4aba53a
Compare
|
LGTM, needs a rebase. |
Bromeon
force-pushed
the
feature/param-lifetimes
branch
from
4aba53a to
4951192
Compare
|
Rebased. Also added the missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for lifetimes in function receiver parameters:
This adds a new type
Lifetimewhich is also reused inGenericArg. I thought that makes more sense than separate(Punct, Ident)tuples, as I could also imagine to add some utility parsing functions in the future. Let me know what you think.Based on #55, the interesting diff is here, in 2 commits.