-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev ip computing #65
Dev ip computing #65
Conversation
Deployment #1
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are many changes to do before merging, especially the one in the DisplayFileCards
file.
ℹ️ Improvement suggestions:
- Maybe simplify the toast at the loading because when you log into IPC, you have 4 toasts and that's not really beautiful.
Simple question because I have never done "real" PR. How to apply changes to PR? Is it enough to push them normally? |
Yep, while the PR isn't merged you can continue to push on the branch and it will count. |
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
…I create an empty post message when loading if there isn't already 1. Then each new program published on IPC. I make an 'amend' on this same post thanks to the hash of the post Signed-off-by: DUBOSCLARD LÉO <[email protected]>
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
…aryCloud into devIPComputing
Description
The first version of the Computing part. Deployment of an HTTP server by uploading a .zip file to Aleph. List of deployed applications.
Changes include
Breaking changes
Added a new button to deploy an application. A new modal to retrieve the file. Change in display to take into account IPCFiles and IPCProgram. New computing.ts file in the lib for interactions between Aleph and the Computing part.
Checklist
Additional comments