Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev ip computing #65

Merged
merged 19 commits into from
Jun 20, 2022
Merged

Dev ip computing #65

merged 19 commits into from
Jun 20, 2022

Conversation

ZerLock
Copy link
Member

@ZerLock ZerLock commented Jun 8, 2022

Description

The first version of the Computing part. Deployment of an HTTP server by uploading a .zip file to Aleph. List of deployed applications.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

Added a new button to deploy an application. A new modal to retrieve the file. Change in display to take into account IPCFiles and IPCProgram. New computing.ts file in the lib for interactions between Aleph and the Computing part.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

⚠️ Cypress testing and documentation will be done this week, while the PR is reviewed.

@ZerLock ZerLock added the enhancement New feature or request label Jun 8, 2022
@ZerLock ZerLock added this to the Computing - V1 milestone Jun 8, 2022
@ZerLock ZerLock linked an issue Jun 8, 2022 that may be closed by this pull request
7 tasks
src/app/AuthRoute.tsx Outdated Show resolved Hide resolved
src/lib/computing.ts Outdated Show resolved Hide resolved
Copy link
Member

@lucas-louis lucas-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many changes to do before merging, especially the one in the DisplayFileCards file.

ℹ️ Improvement suggestions:

  • Maybe simplify the toast at the loading because when you log into IPC, you have 4 toasts and that's not really beautiful.

src/components/DisplayFileCards.tsx Outdated Show resolved Hide resolved
src/components/CustomButtons.tsx Show resolved Hide resolved
src/components/FileCards.tsx Outdated Show resolved Hide resolved
src/lib/computing.ts Outdated Show resolved Hide resolved
@ZerLock
Copy link
Member Author

ZerLock commented Jun 13, 2022

There are many changes to do before merging, especially the one in the DisplayFileCards file.

information_source Improvement suggestions:

  • Maybe simplify the toast at the loading because when you log into IPC, you have 4 toasts and that's not really beautiful.

Currently, there is a maximum of 5 toasts. I agree with you that it's too much but I don't see ones to delete or change.
image

@ZerLock
Copy link
Member Author

ZerLock commented Jun 13, 2022

Simple question because I have never done "real" PR. How to apply changes to PR? Is it enough to push them normally?

@RezaRahemtola
Copy link
Member

Simple question because I have never done "real" PR. How to apply changes to PR? Is it enough to push them normally?

Yep, while the PR isn't merged you can continue to push on the branch and it will count.

ZerLock and others added 6 commits June 13, 2022 10:14
Signed-off-by: DUBOSCLARD LÉO <[email protected]>
…I create an empty post message when loading if there isn't already 1. Then each new program published on IPC. I make an 'amend' on this same post thanks to the hash of the post

Signed-off-by: DUBOSCLARD LÉO <[email protected]>
@adrienfort adrienfort requested a review from lucas-louis June 14, 2022 16:17
@RezaRahemtola RezaRahemtola merged commit 90c2f62 into dev Jun 20, 2022
@adrienfort adrienfort deleted the devIPComputing branch June 21, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Computing V1
7 participants