Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf/bib listes #589

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Perf/bib listes #589

merged 2 commits into from
Dec 6, 2024

Conversation

amandine-sahl
Copy link
Contributor

See issue : #584
+
PR #585

andriacap and others added 2 commits December 5, 2024 15:19
- Load only necessary fields
- Remove useless parameter id=None
- Fix expression "nb_taxons" in BibListes model

Reviewed-by: andriacap
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.36%. Comparing base (a78dd8d) to head (5b5da43).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
apptax/taxonomie/routesbiblistes.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #589      +/-   ##
===========================================
+ Coverage    52.34%   52.36%   +0.02%     
===========================================
  Files           37       37              
  Lines         2432     2427       -5     
===========================================
- Hits          1273     1271       -2     
+ Misses        1159     1156       -3     
Flag Coverage Δ
pytest 52.36% <70.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amandine-sahl amandine-sahl merged commit 6c68e5d into develop Dec 6, 2024
6 checks passed
@amandine-sahl amandine-sahl deleted the perf/bib_listes branch December 6, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants