Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining import of utilssqlalchemy #2786

Closed
wants to merge 10 commits into from

Conversation

jacquesfize
Copy link
Contributor

Plusieurs warnings apparaissent et indiquent l'utilisation de fonction venant utilssqlalchemy (geonature.utils.utilssqlalchemy.py). Cette PR contient les changements suivants :

  • Redirection des imports restants vers UtilsFlaskSQLAlchemy
  • ajout de fonctions de Utilssqlalchemy absentes dans UtilsFlaskSQLAlchemy.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (418e1d9) 68.61% compared to head (778c426) 67.51%.
Report is 48 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2786      +/-   ##
===========================================
- Coverage    68.61%   67.51%   -1.10%     
===========================================
  Files           86       86              
  Lines         7443     7435       -8     
===========================================
- Hits          5107     5020      -87     
- Misses        2336     2415      +79     
Flag Coverage Δ
pytest 67.51% <100.00%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@camillemonchicourt camillemonchicourt added this to the 2.14 milestone Nov 13, 2023
@jacquesfize jacquesfize marked this pull request as ready for review November 13, 2023 09:20
@jacquesfize jacquesfize added database backend dependencies Pull requests that update a dependency file labels Nov 13, 2023
@jacquesfize
Copy link
Contributor Author

Finally, required changes will be integrated with the branch #2751

@jacquesfize jacquesfize deleted the remove-last-old-utilssqlalchemy branch November 30, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend database dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants