Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change sharp version from 0.33.2 to 0.32.6 #302

Closed
wants to merge 1 commit into from

Conversation

abdo-spices
Copy link

image
in other word, when using vite-pwa gets conflict ( a lot of ) because astro and vite uses [email protected]

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

@NikolaRHristov
Copy link
Member

NikolaRHristov commented Mar 11, 2024

Hi, that's a no, unfortunately.

I think there are versions in which we use sharp v0.32.6 specifically: v2.1.5 and up until v2.2.4, which bumps sharp to v0.33.0. You can try using one of the releases with the specified version of sharp: v0.32.6

https://github.com/Playform/AstroCompress/releases/tag/v2.2.3
https://github.com/Playform/AstroCompress/releases/tag/v2.2.2
https://github.com/Playform/AstroCompress/releases/tag/v2.2.1
https://github.com/Playform/AstroCompress/releases/tag/v2.2.0
https://github.com/Playform/AstroCompress/releases/tag/v2.1.6
https://github.com/Playform/AstroCompress/releases/tag/v2.1.5

or the no-sharp branch to exclude sharp and image compression as a whole.

I have been thinking about a solution which adapts AstroCompress to the specified version in Astro package.json. Basically it will read from the root package.json to get the astro version and modify its own package.json to mix and match the both using the node preinstall hook but I'm not sure how that will work and if it will work at all. It's on my TODO list.

@NikolaRHristov NikolaRHristov self-assigned this Mar 11, 2024
@abdo-spices
Copy link
Author

i did already use v2.2.4 but there's a bug with formatting or styling the console code
spices-solutions/fruitUI@56f38ec

@NikolaRHristov
Copy link
Member

What's the bug?

@NikolaRHristov
Copy link
Member

v2.2.4 just introduces display output coloring. Previously the console output was un-styled but the compression is still working.

@NikolaRHristov
Copy link
Member

Also, I can see in your package.json from spices-solutions/fruitUI@56f38ec that you're using "astro-compress": "^2.2.3", which means that a version higher than or v2.2.3, if a higher is not available, will get installed to any platforms not respecting your pnpm-lock.yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants