Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Kustomize version to latest to get rid of Test errors on Mac … #392

Closed

Conversation

stefanvo78
Copy link

Fixed an error for Mac OS with M1. Therefor I changed the version of Kustomize to the newest (4.5.7)

@dgkanatsios
Copy link
Collaborator

so the unit tests break, because make create-install-files makes the git state dirty. This is because newer versions of kustomize rely on a version of go-yaml that incurred a breaking change.

kubernetes-sigs/kustomize#947

There has been a request to fork the project but the fix is still not in kustomize: kubernetes-sigs/yaml#72

The thing is that newer versions of kustomize are MUCH faster. If we use it, this will speed up local development plus end to end tests. To this end, I vote to merge this PR after we validate that the new YAML files work.

@stefanvo78, the only change needed in this PR is to run make create-install-files at the root folder. Thank you!

@dgkanatsios
Copy link
Collaborator

Closing as change was included in #419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants