v0.8.0 - refactor the Storage constructor() to take in an object instead #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louisgv
reviewed
Jul 15, 2022
src/index.ts
Outdated
| @@ -17,6 +17,11 @@ export type StorageCallbackMap = Record<string, StorageWatchCallback> | |||
|
|
|||
| const hasWindow = typeof window !== "undefined" | |||
|
|
|||
| export type StorageConfig = { | |||
There was a problem hiding this comment.
We should infer type instead. I will refactor this a bit.
louisgv
changed the title
louisgv
changed the title
louisgv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This would be a breaking change and require updating the version and the docs.
Currently, the constructor of
Storagerequired you to pass arguments:It's likely cleaner to make it an object, so you can do something like: