Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add position option for inline insertion #790

Merged
merged 3 commits into from
Nov 9, 2023
Merged

feat: Add position option for inline insertion #790

merged 3 commits into from
Nov 9, 2023

Conversation

dvvolynkin
Copy link
Contributor

Details

This PR adds the ability to set the insert position for the inline anchor

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I agree to license this contribution under the MIT LICENSE
  • I checked the current PR for duplication.

@louisgv
Copy link
Contributor

louisgv commented Oct 19, 2023

Thanks for the PR - I will get on reviewing it on the weekends!

@louisgv louisgv changed the title Add position option for inline insertion feat: Add position option for inline insertion Oct 19, 2023
@dvvolynkin
Copy link
Contributor Author

@louisgv
Hello!
Would you mind looking at the pull request when you have a chance?

louisgv
louisgv approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@louisgv louisgv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@louisgv louisgv added this pull request to the merge queue Nov 9, 2023
Merged via the queue into PlasmoHQ:main with commit 6017ec5 Nov 9, 2023
1 check passed
@ericyangpan
Copy link

Is there any example code to use this feature?

@ericyangpan
Copy link

Is there any example code to use this feature?

or documentation

@ViktorTassen
Copy link

Is there any example code or docs to use this feature? Up

@PottyZA PottyZA mentioned this pull request Feb 19, 2024
Closed
2 tasks
@dvvolynkin
Copy link
Contributor Author

It was not working, but I fixed it.
https://github.com/PlasmoHQ/plasmo/pull/907/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samrossetti-overjet samrossetti-overjet samrossetti-overjet left review comments

@louisgv louisgv louisgv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dvvolynkin @louisgv @ericyangpan @ViktorTassen @samrossetti-overjet