Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for deprecated relational operators #82

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Conversation

ZedThree
Copy link
Member

@ZedThree ZedThree commented Oct 9, 2024

Closes #63

One more easy rule for 0.3.0! Explanation could do with a little work though

Copy link
Collaborator

@LiamPattinson LiamPattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a recommendation to switch out the lazy_static BTreeMap for a simpler function using a match statement. Also fixed the test name.

Otherwise all looks good! I'm not really sure what else needs to be added for the explanation.

src/rules/style/relational_symbols.rs Outdated Show resolved Hide resolved
src/rules/style/relational_symbols.rs Outdated Show resolved Hide resolved
src/rules/style/relational_symbols.rs Outdated Show resolved Hide resolved
src/rules/style/relational_symbols.rs Outdated Show resolved Hide resolved
src/rules/style/relational_symbols.rs Outdated Show resolved Hide resolved
@ZedThree ZedThree changed the title Add rule for old style relational symbols Add rule for deprecated relational operators Oct 10, 2024
@LiamPattinson
Copy link
Collaborator

All looks good!

@LiamPattinson LiamPattinson merged commit dbda3c9 into main Oct 10, 2024
22 checks passed
@ZedThree ZedThree deleted the relational-symbols branch October 10, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefer > over .gt. etc
2 participants