Add rule for missing label on exit
/cycle
#53
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly following the equivalent rule in
stylist
except:cycle
as well asexit
do
loops with a nameexit/
cycle` in nested loopsLast point could probably be fixed with some more sophisticated logic: walking the tree, and only descending into non-
do
nodes. Then I think we'd be able to confidently suggest the correct label for a fix.Second point could be turned into another rule:
exit
/cycle
in nested loops should be labelled.Also, I've just put this into the "style" category, but I'm not sure that's completely appropriate. Maybe we need some community input into the categorisation of rules.