Optimise tree sitter usage #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was fixed by switching from children() to named_children()
It'll make it easier to iterate over rules later
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
Results in a massive speed up. Running on the GS2
srcdirectory, it used to take about 5.5 seconds on my laptop, but now takes under 0.5s.The method to achieve this isn't great, as now every rule needs to declare 'entrypoints' that must match its method type. The process of generating a map from entrypoints to
(rule_code, rule)is a little messy too. It would be better to use some fancy macros, enums and match statements instead, but the current methods work well enough.