-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gamma_c (Nemov and Velasco et. al) Γ_c #1042
Merged
Changes from 123 commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
a4f947f
Add Gamma_c to neoclassical compute quantities
unalmis 069036f
Merge branch 'ripple' into Gamma_c
unalmis 2cea638
Update thing after merge
unalmis 03694a0
Merge branch 'ripple' into Gamma_c
unalmis c17a9df
Add Gamma_c plot
unalmis c616ee5
Merge branch 'ripple' into Gamma_c
unalmis e0dffc6
Merge branch 'ripple' into Gamma_c
unalmis 4947bee
Add Gamma_c objective function
unalmis 08af99d
Merge branch 'ripple' into Gamma_c
unalmis 9979ab5
Fix docstring
unalmis 0810075
Merge branch 'ripple' into Gamma_c
unalmis 5956349
Update Gamma_c test after merge
unalmis 39f9ade
Merge branch 'ripple' into Gamma_c
unalmis 19b58ba
Merge branch 'ripple' into Gamma_c
unalmis 802e4ba
Merge branch 'ripple' into Gamma_c
unalmis b6f0614
Merge branch 'ripple' into Gamma_c
unalmis a6c29df
Fix calls to rtz_grid after merge
unalmis 36d5e82
Merge branch 'ripple' into Gamma_c
unalmis 18960f8
Merge branch 'ripple' into Gamma_c
unalmis f3361cb
average before integration to reduce computation
unalmis 10e9937
Merge branch 'ripple' into Gamma_c
unalmis e8f240d
Merge branch 'ripple' into Gamma_c
unalmis ad7f2b6
Merge branch 'ripple' into Gamma_c
unalmis e6adeb2
remove unused jitable arg causing error
dpanici 1462d28
remove unneeded jitable call
dpanici 0bf73b4
Merge branch 'ripple' into Gamma_c
unalmis 7a50240
Merge branch 'ripple' into Gamma_c
unalmis 0348288
Merge branch 'ripple' into Gamma_c
unalmis 1c8d4eb
Only get profiles in objective build method
unalmis 29903ed
Merge branch 'ripple' into Gamma_c
unalmis 2ab29a9
Add num_wells parameter to increase performance
unalmis 6b7bcfb
Merge branch 'ripple' into Gamma_c
unalmis a0d68fe
Merge branch 'ripple' into Gamma_c
unalmis 67586ff
Add num_wells to Gamma_c objective
unalmis 204dea8
Merge branch 'ripple' into Gamma_c
unalmis 6ec5bd2
Add num_wells as static parameter to compute fun
unalmis 29d1e8d
Merge branch 'ripple' into Gamma_c
unalmis 2c54f9d
Specify kwargs for trapezoid integration after quadax API changes fro…
unalmis 921f4d5
Add Nemov's Gamma_c
unalmis 5ca2630
Remove hanging plt.show() from last commit
unalmis cd3b6b6
Fix comment
unalmis 4577d4f
Fix another comment
unalmis d528b33
Merge branch 'ripple' into Gamma_c
unalmis 67d0662
Merge branch 'ripple' into Gamma_c
unalmis 4595546
Fix reshape error raised by JAX by reverting average before pitch int…
unalmis f0ad787
Merge branch 'ripple' into Gamma_c
unalmis e0dfd61
Merge branch 'ku/angles' into Gamma_c
unalmis 75bc784
Use general angles rather than stream function aliases
unalmis 72fb5e6
Merge branch 'ripple' into Gamma_c
unalmis 75c9333
Merge branch 'ripple' into Gamma_c
unalmis d2bfe12
Merge branch 'ripple' into Gamma_c
unalmis 2363303
Atone for B0 name change made in pull request #1168
unalmis 4cea229
Merge branch 'ripple' into Gamma_c
unalmis ba758d6
Merge branch 'ripple' into Gamma_c
unalmis 4216094
Merge branch 'ripple' into Gamma_c
unalmis d94ecd6
Update Gamma_c objective for recent changes on master
unalmis 5cd7ebd
Add Gamma_c_Nemov baseline image for test
unalmis df2938e
Merge branch 'ripple' into Gamma_c
unalmis 717426f
Merge branch 'ripple' into Gamma_c
unalmis c2e455d
Allow using other Gamma_c in objective
unalmis 3d44b04
Merge branch 'ripple' into Gamma_c
unalmis 9ed4a47
black format
unalmis 070626b
Merge branch 'ripple' into Gamma_c
unalmis 246427b
Merge branch 'ripple' into Gamma_c
unalmis 621cb71
Merge branch 'ripple' into Gamma_c
unalmis a5a257b
Merge branch 'ripple' into Gamma_c
unalmis 4d3169b
Merge branch 'ripple' into Gamma_c
unalmis 55f8aa5
Merge branch 'master' into Gamma_c
unalmis 9498ad4
Merge branch 'ripple' into Gamma_c
unalmis 7894b41
Merge branch 'ripple' into Gamma_c
unalmis 9acc900
Use infinite period for alpha
unalmis e31b602
Use better quadrature for part of integral in Nemov Gamma_c
unalmis a574827
Add quad2 kwargs for weak singular integrals
unalmis cff5494
Merge branch 'ripple' into Gamma_c
unalmis 503f0d6
Avoid redundant computation of bounce points
unalmis 362f198
Merge branch 'ripple' into Gamma_c
unalmis 48d92fb
Merge branch 'ripple' into Gamma_c
unalmis 3714827
Merge branch 'ripple' into Gamma_c
unalmis 1739b3e
Merge branch 'ripple' into Gamma_c
unalmis 9dac89e
Document that Velasco's expression converges to zero
unalmis 5a8e861
Merge branch 'ripple' into Gamma_c
unalmis 7268ad8
Update after merging
unalmis b58a1bd
Merge branch 'ripple' into Gamma_c
unalmis 5b668ee
Merge branch 'ripple' into Gamma_c
unalmis eef81f6
Merge branch 'ripple' into Gamma_c
unalmis 507a30c
Merge branch 'ripple' into Gamma_c
unalmis 021b28a
Add chunk_size option
unalmis 1a62674
Merge branch 'ripple' into Gamma_c
unalmis 3f465d6
Merge branch 'ripple' into Gamma_c
unalmis 157359d
Merge branch 'ripple' into Gamma_c
unalmis 53ea40b
Merge branch 'ripple' into Gamma_c
unalmis 779f57c
Make sure API is compatible for Gamma_d etc.
unalmis 954b9ec
address my review comment
unalmis bc5f6d3
Resolve todo comment out smoothness
unalmis 5b8ccb7
Merge branch 'ripple' into Gamma_c
unalmis f6aee2c
Merge branch 'ripple' into Gamma_c
unalmis e5127e0
Merge remote-tracking branch 'refs/remotes/origin/Gamma_c' into Gamma_c
unalmis 21c2e6b
fix method name in gammaC compute call
dpanici e13bdaf
Merge branch 'ripple' into Gamma_c
unalmis d5f4473
Update comment about convergence to zero with warning to use adaptive…
unalmis 1797fcc
Merge branch 'ripple' into Gamma_c
unalmis b83fed8
Merge branch 'ripple' into Gamma_c
unalmis 2e74569
Merge branch 'ripple' into Gamma_c
unalmis 9ffb527
Merge branch 'ripple' into Gamma_c
unalmis 090ef23
Merge branch 'ripple' into Gamma_c
unalmis 5be0f27
Merging ripple
unalmis 7db67d6
Merge branch 'ripple' into Gamma_c
unalmis 563a67c
Merge branch 'ripple' into Gamma_c
unalmis 6c1b647
Merge branch 'ripple' into Gamma_c
unalmis bcc0dd0
Merge branch 'ripple' into Gamma_c
unalmis 67ba404
Merge branch 'ripple' into Gamma_c
dpanici 158fade
Merge branch 'ripple' into Gamma_c
unalmis 27cfacf
fixing #1288, adding opt tests for Gamma_c
2f8ba3c
Revert "fixing #1288, adding opt tests for Gamma_c"
0257d91
Merge branch 'ripple' into Gamma_c
unalmis 57d983f
Merge part 1
unalmis f7b6267
Merge branch 'ripple' into Gamma_c
unalmis c3a7296
Merging part 2
unalmis 6057ec5
Merge branch 'ripple' into Gamma_c
unalmis 7860d61
Merge branch 'master' into Gamma_c
unalmis 231c643
Merge branch 'master' into Gamma_c
unalmis 751ce53
Merge branch 'master' into Gamma_c
unalmis b505e70
Merge branch 'master' into Gamma_c
rahulgaur104 ec937d5
Review requests
unalmis 86a0c2f
Review request 2
unalmis 3c582e2
Merge branch 'master' into Gamma_c
unalmis c312aa1
review request to make objective only allow kwarg
unalmis ce98913
Merge branch 'master' into Gamma_c
unalmis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made this cosmetic change so that it shows up in git diff and reviewer can confirm new quantities of this form are correct by comparison.