Skip to content
This repository has been archived by the owner on Jan 16, 2024. It is now read-only.

Feature/new donations #1908

Closed
wants to merge 241 commits into from
Closed

Feature/new donations #1908

wants to merge 241 commits into from

Conversation

harshvitra
Copy link
Collaborator

@harshvitra harshvitra commented Feb 6, 2020

Fix #1098
Fix #1165
Fix #1411
Fix #1356

Draft PR for New Donations.

This PR brings donations to the application.
We are implementing contextual donations, where the app is able to understand the context in which the donations is being made and it can process the donations using those contexts.

The different sections in the process are -

1. Donation To -

  • If the user has reached directly on this page from some link: The app will show Select Project section.
    The app shows an option to select project where the user is redirected to the projects list page and user selects a project.

  • If the user has selected a project: This section will have the Project name, project image, the cost per tree, and the currency selection option. It will also show an option to change project. This option is conditional -
    Show the option to change project when:

  1. The user has selected a project and reached this page.
  2. The user is gifting trees to someone
    Don't show the option to change project when:
  3. User is pledging for an event, which has a project associated.
  4. User is supporting a competitor, competition may or may not have a project associated. If project is not associated we give the option to change project.

2. Tree count selection -

  • Show the option to select the number of trees they are donating. Show this option when user selected a project, or gifting trees or supporting a competitor, projects have treeCountOptions in the API which will give the list of options, if not in the API we give them the default options - 10, 20, 50, 150 and custom.

  • If the user has pledged some amount of trees we don't allow them to select tree count. We give them the custom trees option where they can only increase the treeCount.

3. Frequency -

  • Add 3 options - Once, monthly and Annually, where user can have recurrent donations.

4. If pledge events -

  • Show event name, pledged date, pledge event image. Also select the treeCount based on pledged trees.

5. If Gift trees -

  • Shows name and image of user who will receive of gift, and give option to select treeCount. Also give an
    option to add recipient (Multiple Gifts).

6. Show Contact details -

  • Shows company name, address and email id of the user if the user has previously added this. Also give an option to edit details, which will take the user to the 2nd screen where they enter details.

7. Show Payment details -

  • Shows payment details of the user if the user has previously added this. Also give an option to edit details, which will take the user to the 3nd screen where they enter details.

8. Tax deduction option -

  • Show option to receive a tax deduction receipt and change country for which receipt is being received.

Collecting open issues from comments here:

@norbertschuler norbertschuler added the old-config version not using the new .env.develop instead of config/index.js.dist label Feb 19, 2020
@norbertschuler norbertschuler removed the old-config version not using the new .env.develop instead of config/index.js.dist label Mar 9, 2020
@norbertschuler
Copy link
Collaborator

@harshvitra build still has problems:

error Unable to resolve module `./../components/PaymentMethods/NativePay` from `app/components/DonateTrees/screens/DonationDetails.native.js`: 

- also I cannot change uppercase for a folder on MacOS into Git
@norbertschuler
Copy link
Collaborator

@harshvitra build still has problems:

error Unable to resolve module `./../components/PaymentMethods/NativePay` from `app/components/DonateTrees/screens/DonationDetails.native.js`: 

Fixed (also my preferred fix to change the folder name did not work on MacOS with Git).

@harshvitra
Copy link
Collaborator Author

@harshvitra build still has problems:

error Unable to resolve module `./../components/PaymentMethods/NativePay` from `app/components/DonateTrees/screens/DonationDetails.native.js`: 

Fixed (also my preferred fix to change the folder name did not work on MacOS with Git).

On my local machine changing file name didn't get recorded in the git log because it was just lower case to upper case

@Chiagozie-Udeh
Copy link
Collaborator

The different sections in the process are -

  1. Donation To -

If the user has reached directly on this page from some link: The app will show Select Project section.
The app shows an option to select project where the user is redirected to the projects list page and user selects a project.

This one works quite well.

If the user has selected a project: This section will have the Project name, project image, the cost per tree, and the currency selection option. It will also show an option to change project. This option is conditional -
Show the option to change project when:

The user has selected a project and reached this page.
The user is gifting trees to someone

Doesn't show the option to change project for both conditions

  1. Tree count selection -

Show the option to select the number of trees they are donating. Show this option when user selected a project, or gifting trees or supporting a competitor, projects have treeCountOptions in the API which will give the list of options, if not in the API we give them the default options - 10, 20, 50, 150 and custom.

Works fine

If the user has pledged some amount of trees we don't allow them to select tree count. We give them the custom trees option where they can only increase the treeCount.

Couldn't test

  1. Frequency -

Add 3 options - Once, monthly and Annually, where user can have recurrent donations.

Couldn't test

  1. If pledge events -

Show event name, pledged date, pledge event image. Also select the treeCount based on pledged trees.

This works very well

  1. If Gift trees -

Shows name and image of user who will receive of gift, and give option to select treeCount. Also give an
option to add recipient (Multiple Gifts).

Option for multiple gifts not showing yet. Only one gift at a time still.

  1. Show Contact details -

Shows company name, address and email id of the user if the user has previously added this. Also give an option to edit details, which will take the user to the 2nd screen where they enter details.

Couldn't test

  1. Show Payment details -

Shows payment details of the user if the user has previously added this. Also give an option to edit details, which will take the user to the 3nd screen where they enter details.

Works fine

  1. Tax deduction option -

Show option to receive a tax deduction receipt and change country for which receipt is being received.

Work very fine

# Conflicts:
#	app/actions/apiRouting.js
@@ -143,6 +150,7 @@
"tcomb-form": "^0.9.21",
"tcomb-form-native": "^0.6.20",
"tcomb-json-schema": "^0.3.2",
"tipsi-stripe": "git+https://github.com/tipsi/tipsi-stripe.git#experimental",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this is going to be released, we should check if we can change this to an officially released version. The latest beta release is [8.0.0-beta.10] - 2020-04-02 https://github.com/tipsi/tipsi-stripe/blob/master/CHANGELOG.md#800-beta10---2020-04-02 and there has not happened very much since then https://github.com/tipsi/tipsi-stripe/graphs/commit-activity - the overall activity of this repository seems to be quite low.

# Conflicts:
#	ios/Podfile.lock
#	package.json
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
old react-native version using old react-native version <0.6.x Should we close this?
Projects
None yet
9 participants