Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liftoff allows single base introns #89

Open
GallVp opened this issue Nov 7, 2024 · 4 comments
Open

Liftoff allows single base introns #89

GallVp opened this issue Nov 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@GallVp
Copy link
Member

GallVp commented Nov 7, 2024

Description of the bug

Single base introns do not make sense and also breaks the GXF_FASTA_AGAT_SPADDINTRONS_SPEXTRACTSEQUENCES subworkflow at

.collect { el -> [ el.id, "${el.seqString[0..1]}${el.seqString[-2..-1]}" ].join('\t') }

Command used and terminal output

No response

Relevant files

No response

System information

plant-food-research-open/genepal 0.4.0

@GallVp GallVp added the bug Something isn't working label Nov 7, 2024
@GallVp GallVp self-assigned this Nov 7, 2024
@GallVp GallVp added this to the 0.5.0 milestone Nov 7, 2024
@GallVp
Copy link
Member Author

GallVp commented Nov 9, 2024

Use agat/sp_sp_flag_short_introns.pl to mark any intron shorter than 10 and filter the corresponding genes. Relevant issues and PRs,

@GallVp GallVp linked a pull request Nov 11, 2024 that will close this issue
10 tasks
@GallVp GallVp closed this as completed Nov 21, 2024
@GallVp GallVp reopened this Dec 19, 2024
@GallVp GallVp removed this from the 0.5.0 milestone Dec 19, 2024
@GallVp
Copy link
Member Author

GallVp commented Dec 19, 2024

There are cases where agat/sp_sp_flag_short_introns.pl version quay.io/biocontainers/agat:1.4.1--pl5321hdfd78af_0 does not flag 1 bp introns. See NBISweden/AGAT#516

This results in a pipeline crash by gxf_fasta_agat_spaddintrons_spextractsequences splice motif extraction logic. The crash can be averted by assigning '' as a motif for less than 4 bp introns.

@GallVp
Copy link
Member Author

GallVp commented Dec 19, 2024

Fix PR for gxf_fasta_agat_spaddintrons_spextractsequences GallVp/nxf-components#51

@GallVp GallVp removed a link to a pull request Dec 19, 2024
10 tasks
@GallVp
Copy link
Member Author

GallVp commented Dec 19, 2024

Fix PR for short intron crash #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant