Made the hic param pattern more flexible
#131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
For visibility, @SarahBailey1998, @ignacio3437 |
GallVp
commented
Sep 18, 2024
| script "./hicparam.nf" | ||
| function "checkHiCParam" | ||
|
|
||
| test("Dummy_hic.R{1,2}.fq.gz") { |
There was a problem hiding this comment.
@SarahBailey1998, @ignacio3437
The permissible patterns are tested here. Are we missing something?
There was a problem hiding this comment.
would "dummy_hic_{1,2).merged.fastq.gz be allowed?
There was a problem hiding this comment.
If you mean: dummy_hic_{1,2}.merged.fastq.gz and not dummy_hic_{1,2).merged.fastq.gz, then yes.
The permissible pattern is ^\S+\{1,2\}[\w\.]*\.f(ast)?q\.gz$
\S+ will cover the dummy_hic_ part
We can test it here: https://regex101.com
There was a problem hiding this comment.
yeah that's what I mean, I made a typo sorry! Awesome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
hicparam pattern more flexiblenf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).