chore(A2-1478): update to node 20 #3900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryn-pins
force-pushed
the
chore/node-20
branch
from
1c07e2d to
6ad3e5c
Compare
bryn-pins
force-pushed
the
chore/node-20
branch
from
6ad3e5c to
9a7f1e8
Compare
bryn-pins
force-pushed
the
chore/node-20
branch
2 times, most recently
from
49c05da to
09b4210
Compare
beejjacobs
previously approved these changes
Nov 8, 2024
bryn-pins
force-pushed
the
chore/node-20
branch
from
09b4210 to
ac781ae
Compare
bryn-pins
force-pushed
the
chore/node-20
branch
from
ac781ae to
3ab56c5
Compare
beejjacobs
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Number
https://pins-ds.atlassian.net/browse/A2-1478
Description of change
Update to node 20
Node >19 changes the default setting of http/s agents to use keep alive true, and the clients experience failures with this
Have set the global instance value for both to false
nodejs/node#47130
node-fetch/node-fetch#1767
axios/axios#5929
Checklist
Important
Please do not merge from
main(please only rebase). This keeps the history linear and easier to debug.