Update placekey.js (#47)

* Update placekey.js * Update test.yml Updating node in test * Update test.yml Test updates * Removed yarn changes
Placekey · Sep 24, 2024 · 51de4ac · 51de4ac
1 parent 2dc2ce6
commit 51de4ac
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -16,7 +16,7 @@ jobs:
 
       - uses: actions/setup-node@v1
         with:
-          node-version: 12.x
+          node-version: 18.x
 
       - name: Bootstrap
         run: |

diff --git a/src/lib/placekey.js b/src/lib/placekey.js
@@ -65,7 +65,8 @@ const REPLACEMENT_MAP_FORWARD = {
 const FIRST_TUPLE_REGEX = `[${ALPHABET}${REPLACEMENT_CHARS}${PADDING_CHAR}]{3}`;
 const TUPLE_REGEX = `[${ALPHABET}${REPLACEMENT_CHARS}]{3}`;
 const WHERE_REGEX = new RegExp(`^${[FIRST_TUPLE_REGEX, TUPLE_REGEX, TUPLE_REGEX].join('-')}$`);
-const WHAT_REGEX = new RegExp(`^[${ALPHABET}]{3,}(-[${ALPHABET}]{3,})?$`);
+const WHAT_REGEX_V1 = new RegExp(`^[${ALPHABET}]{3,}(-[${ALPHABET}]{3,})?$`);
+const WHAT_REGEX_V2 = new RegExp('^[01][abcdefghijklmnopqrstuvwxyz234567]{9}$');
 
 // Boolean for whether or not a Placekey is valid.
 export function placekeyIsValid(placekey) {
@@ -82,7 +83,9 @@ export function placekeyIsValid(placekey) {
   }
 
   if (what) {
-    return Boolean(where.match(WHERE_REGEX) && what.match(WHAT_REGEX));
+    return Boolean(
+      where.match(WHERE_REGEX) && (what.match(WHAT_REGEX_V1) || what.match(WHAT_REGEX_V2))
+    );
   }
   return Boolean(where.match(WHERE_REGEX));
 }

diff --git a/test/placekey.spec.js b/test/placekey.spec.js
@@ -50,6 +50,7 @@ test('placekeyIsValid', t => {
   t.ok(placekeyIsValid('222-zzz@abc-234-xyz'), 'double tuple what with where');
   t.ok(placekeyIsValid('2222-zzz@5vg-7gq-tvz'), 'long address encoding with where');
   t.ok(placekeyIsValid('222-zzzz@5vg-7gq-tvz'), 'long poi encoding with where');
+  t.ok(placekeyIsValid('1wvpg5h3st@628-tgw-z9f'), 'placekey fits V2');
   t.ok(
     placekeyIsValid('22222222-zzzzzzzzz@5vg-7gq-tvz'),
     'long address and poi encoding with where'