Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix my issue for Docker Images #26

Closed
wants to merge 4 commits into from
Closed

Fix my issue for Docker Images #26

wants to merge 4 commits into from

Conversation

unixhelden
Copy link

#25

Tried to fix another bug and had problems getting everything up and running. Took the Time to provide Docker setup for Development. Bug Fix for the requested Patch on Discord will follow.

Greetings, your Streamtroll :)

unixhelden added a commit to unixhelden/FocusBlock that referenced this pull request Jul 14, 2018
@unixhelden
Doooh and even an error in =>
96dbfe3 
PixelogicDev#26
@adilanchian adilanchian self-requested a review July 14, 2018 06:46
adilanchian
adilanchian requested changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@adilanchian adilanchian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking awesome :) Just a couple pieces of feedback before we merge this in:

  1. Can you set the base branch to be release-1.0.1 please?

  2. Would you be able to explain more to me if this would be affecting building the app for production and a good way to run some local tests on this?

Thank you!

@unixhelden
Change some behavior how the Database is defined, changed the Documen…
27341a2 
…tation for it so that the Docker Image could be composed together and still work.

Doooh and even an error in =>
PixelogicDev#26
@unixhelden
Add GitIgnore File for Vscode and WebStorm, also make sure that the M…
1e2d327 
…ongoDB Date from the DockerImage will be commited.
@unixhelden
Add Nginx Config File so the Application can be accessed via http://$…
da173be 
…hostname
@unixhelden
Finalize Docker stuff for:
3051822 
PixelogicDev#25
@unixhelden
Copy link
Author

Hi Alec, i rebased onto release-1.0.1.

Yes, if you do not change your .ENV for Backend it will propably break.
I changed the Readme.md to reflect this.

Local Test:
Checkout my fork :) Have Docker installed and run docker-compose up in the Project Dir.
After success you should be able to see a working Focus Block running on http://localhost:80

Database Files should reside in MongoDB/*.
I have excluded node_modules, they will be generated in the containers. Because it seems like the Frontend uses a OS specific Version of a Sass Compiler. So if you run npm -i on your main Desktop it will not work in the Container.

unixhelden added a commit to unixhelden/FocusBlock that referenced this pull request Jul 14, 2018
@unixhelden
Change some behavior how the Database is defined, changed the Documen…
9ae540e 
…tation for it so that the Docker Image could be composed together and still work.

Doooh and even an error in =>
PixelogicDev#26
@unixhelden unixhelden changed the base branch from master to release-1.0.1 July 14, 2018 13:34
@unixhelden unixhelden closed this Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adilanchian adilanchian adilanchian requested changes

Assignees

@unixhelden unixhelden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unixhelden @adilanchian