Patch to allow building libpng on Macs with modern build system #1946
Conversation
slingthor
force-pushed
the
libpng-building-on-mac
branch
from
5f749d1
to
00f3ee6
Compare
|
Please note that there is a fix here - pnggroup/libpng#403 - although it seems unlikely to land in a timely manner. Sadly the author of libpng passed away, and there aren't currently active maintainers (brief discussion here: pnggroup/libpng#410) |
slingthor
force-pushed
the
libpng-building-on-mac
branch
from
00f3ee6
to
1a2bb9f
Compare
I agree the best way to work around it would be at the libpng level. Yea had heard about the author passing away, that's really sad. |
build_scripts/build_usd.py
Outdated
| ("add_custom_target(genfiles DEPENDS", | ||
| "add_custom_target(genfiles DEPENDS gensym symbol-check")]) | ||
|
|
||
| RunCMake(context, force, buildArgs) |
There was a problem hiding this comment.
This is missing the "+ macArgs" that is needed to pass the Neon optimization args for Arm builds down to RunCMake().
slingthor
force-pushed
the
libpng-building-on-mac
branch
2 times, most recently
from
9033722
to
93a5dd3
Compare
|
Thanks for the valuable feedback so far guys! I've updated the PR to reflect the comments made! |
|
We've come to notice, that perhaps this is only happening for those who generate the project with --generator Xcode. |
slingthor
force-pushed
the
libpng-building-on-mac
branch
from
93a5dd3
to
78687b9
Compare
|
Filed as internal issue #USD-7489 |
It looks as if there's an issue with the CMake code for PNG with modern XCode: PixarAnimationStudios/OpenUSD#1946 pnggroup/libpng#403 This commit makes a stab at adapting the version from libpng/libpng#2 onto our (somewhat simplified) png build. It looks as if libpng doesn't currently have much in the way of an active upstream (no new releases in a number of years), so will need to keep an eye out to see what the eventual solution is.
|
@slingthor @davidgyu pnggroup/libpng#403 has landed! |
With the libPNG upgrade to v1.6.38 in #1959 this patch isn't required. |
|
Closed as no longer needed |
This version includes improved support for Xcode in addition to other maintenance fixes. Contribution: Jon Creighton Fixes #1946 (Internal change: 2268616)
Description of Change(s)
Patches the building of libpng to work around an error when building with the modern build system.
Prevents the command generating pnglibconf.c from being attached to the following build targets:
genvers
gensym
genfiles
Since none of these targets are are common dependency of each other, this causes an error and is not allowed by the Xcode modern build system.
Fixes Issue(s)
-Unable to build libpng on MacOS with modern build system