Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Fixes for Xcode builds and debugging #1959

Closed

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Jul 22, 2022

Description of Change(s)

This PR combines the work in the following two PRs:

#1937
#1946

In addition, Xcode builds require code signing. This has been added as a separate python file, apple_utils.py

Debugging usdview or usdrecord in Xcode requires using the python executable. However this is does not have the necessary entitlements for debugging, so Xcode will not connect. To fix this, it is necessary to disable System Integrity Protection (SIP) in the Recovery OS. You should only disable SIP temporarily to perform the debugging, and reenable it as soon as possible. Failure to reenable SIP when you are done testing leaves your computer vulnerable to malicious code.

More information and instructions on how to disable SIP can be found here:

https://developer.apple.com/documentation/security/disabling_and_enabling_system_integrity_protection

Fixes Issue(s)

  • Building and debugging in Xcode
  • I have submitted a signed Contributor License Agreement

@creijon creijon changed the base branch from release to dev July 22, 2022 10:52
@creijon creijon changed the title APPLE: Combine PNG fix and Xcode debugging fix APPLE: Fixes for Xcode builds and debugging Jul 22, 2022
@sunyab
Copy link
Contributor

sunyab commented Jul 28, 2022

Filed as internal issue #USD-7517

@creijon creijon force-pushed the jon/dev/xcode_fixes branch from e3f5b17 to e591917 Compare August 2, 2022 04:36
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from e591917 to 496b066 Compare August 16, 2022 05:22
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 0bd1a52 to 17313f6 Compare September 5, 2022 08:54
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 42b37b8 to 1799d43 Compare September 11, 2022 07:28
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 2b3179b to ff43773 Compare September 22, 2022 10:41
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from cef9b8d to b002823 Compare October 3, 2022 07:02
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from b002823 to 40e7a3e Compare October 18, 2022 19:55
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 40e7a3e to 9d1b568 Compare October 26, 2022 10:00
@meshula
Copy link
Member

meshula commented Oct 26, 2022

This diff is getting pretty small, introducing an env var to point to the libraries for debugging, and also bumping the libpng version. Is the libpng version bump related to xcode building and debugging? If no, maybe that bump should be split out into its own PR.

@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 940475b to 4fef98a Compare November 9, 2022 18:38
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 4fef98a to af921df Compare November 17, 2022 13:03
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from e2d9ec5 to 9cf2126 Compare November 29, 2022 11:50
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 0a2fa33 to 6c81a26 Compare December 3, 2022 06:59
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 6c81a26 to 6385a5b Compare December 10, 2022 08:17
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 6385a5b to 13a2acc Compare January 6, 2023 13:26
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 13a2acc to 854d8ec Compare January 15, 2023 14:26
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 2 times, most recently from 941092e to 3fd7aea Compare January 30, 2023 08:36
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 3fd7aea to 22e3036 Compare February 7, 2023 22:49
@creijon creijon force-pushed the jon/dev/xcode_fixes branch 3 times, most recently from 2a1e6be to 426bf00 Compare February 24, 2023 18:12
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 426bf00 to 311f593 Compare March 2, 2023 13:16
@creijon creijon force-pushed the jon/dev/xcode_fixes branch from 311f593 to d4b4a6b Compare March 17, 2023 06:39
@davidgyu
Copy link
Member

davidgyu commented Apr 3, 2023

We've merged the libpng version update with dev commit 63a7c17

The changes to base/lib/plug aren't needed since you can specify multiple plugin search path locations via the existing PXR_PLUGINPATH_NAME environment variable as described in BUILDING.md, e.g. "<installdir>/lib/usd:<installdir>/plugin/usd"

@tallytalwar
Copy link
Contributor

Closing as per @davidgyu 's comments above. Thanks all.

@tallytalwar tallytalwar closed this Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants