removes redundant "vals" namespace from the primvars namespace when r… #1635
Conversation
…eading array primvars from alembic
|
Thanks, @BSalem ! If there is no existing test case that changes as a result, would it be possible for you to add one? |
|
would it be enough to add to the PR an alembic archive with two primvars (two color sets, one called vals - just in case! And the other called colorSet), that then read in usdview showing properly named primvars and properly returned values? (actually that's only how I tested it at my end). |
|
Sure, @BSalem ! Have a look at the existing usdAbc tests, the majority of which are baseline-comparison tests. So you just take your simple abc file, run it through usdcat to get a usda equivalent (good to verify that it produces the bad output without your fix), and add a py file that effectively reruns usdcat. I'd maybe look at testUsdAbcIndexedProperties, including what gets added to the CMakeLists.txt to perform the baseline diff. Thanks! |
…eading array primvars from alembic implemented test
|
Hi @spiffmon, I implemented a similar test, please let me know if this is OK |
pxr/usd/plugin/usdAbc/CMakeLists.txt
Outdated
| pxr_register_test(testUsdAbcIndexedGeomArb | ||
| PYTHON | ||
| COMMAND "${CMAKE_INSTALL_PREFIX}/tests/testUsdAbcIndexedGeomArb" | ||
| DIFF_COMPARE bad_primvars_namespace_before_fix.usda |
There was a problem hiding this comment.
Shouldn't we be comparing to the "good" , after-fix baseline, here? And I don't think we need the "bad" version included in the PR - I only mentioned it so that you could have an extra validation that your fix works by running the test against the good baseline, without your fix, to see that the test fails, a la test-driven development.
Thanks, @BSalem !
There was a problem hiding this comment.
to be honest, I didn't ever work with tests modules, so I'm not familiar with their dependencies and how it work... I blindly followed the example you shared.
I just pushed an updated one though.
|
Filed as internal issue #USD-6940 |
Invoke usdcat directly instead of going through the test script which simply does the same thing. This is similar to how the usdcat tests are set up and avoids issues where usdcat may not be in the PATH when the test is run. See #1635 (Internal change: 2217289)
removes redundant "vals" namespace from the primvars namespace when reading array primvars from alembic