Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usdAbc] fixed reading indexed attributes #864

Closed
wants to merge 1 commit into from
Closed

[usdAbc] fixed reading indexed attributes #864

wants to merge 1 commit into from

Conversation

AlexSchwank
Copy link
Contributor

Description of Change(s)

Fixes Issue(s)

pxr/usd/plugin/usdAbc/alembicReader.cpp Show resolved Hide resolved
custom matrix4d xform:vals
matrix4d xform:vals.timeSamples = {
custom matrix4d xform
matrix4d xform.timeSamples = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's independent of this change, but this change in output hilites a problem we should probaly catch and fix: if alembic allows arbitrary properties to be indexed, we can't support that, since USD only allows indexing of primvars. So if we find anything other than an arbGeom property that's indexed, we should flatten it on the Alembic side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this points to two more problems:

  • in this case "vals" shouldn't be removed as there are no indices
  • the xform attribute isn't really used in this prim

@jilliene
Copy link

jilliene commented Jun 6, 2019

Filed as internal issue #USD-5348

@cameronwhite
Copy link
Contributor

I encountered similar issues and saw that PR #1635 already fixed the :vals suffix, but the int[] issue for indices still remains

@AlexSchwank - would you be able to rebase your changes? If you don't have time to work on this, I could also put together an updated PR

@AlexSchwank AlexSchwank closed this by deleting the head repository Feb 29, 2024
AdamFelt pushed a commit to autodesk-forks/USD that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants