-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Usd] Boost Noncopyable #645
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes it from all code not directly interacting with boost::python. (Slowly) inching closer to boost possible becoming an optional dependency, only required for python. |
Filed as internal issue #USD-4810. |
Further reduce dependence on boost in hopes of a brighter future of magnificent compile times.
This was transitively relying on includes from sdf, but rather than just adding the include, might as well remove boost here while I'm at it.
superfunc
force-pushed
the
boostNoncopyable
branch
from
August 4, 2019 21:52
e3005b8
to
c1f0039
Compare
Rebased this one; keeping it as separate commits as thats generally the Pixar preference. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This merges closed PRs (#630, #629, #621, #618), into a single one. The commits remain separate, so they are clearer and more testable. My hope is that this lightens the load on team USD, and can facilitate getting this merged sooner rather than later.