Fix the code for calculating mesh points on Capsule_1 prims #3129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erent top and bottom radii. The code to calculate the angle between the spheres was incorrect.
|
Filed as internal issue #USD-9778 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the code for calculating mesh points on Capsule_1 prims with different
top and bottom radii. The code to calculate the angle between the spheres was incorrect.
Description of Change(s)
The code used to use acos(rdiff/height) to calculate the angle between the top and bottom spheres, but rdiff/height is opposite/adjacent for the angle of interest, and so needed to use atan to return the correct value.
Fixes Issue(s)
Capsule_1 rendering breaks when top/bottom radii are different #3113
[ X ] I have verified that all unit tests pass with the proposed changes
[ X ] I have submitted a signed Contributor License Agreement