Support namespaces in propertyNamespacePrefix for usdGenSchema
#3090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crevilla
reviewed
May 17, 2024
crevilla
reviewed
May 17, 2024
nvmkuruc
force-pushed
the
fixmultiapplynamespace
branch
3 times, most recently
from
9c67fdf
to
4308221
Compare
nvmkuruc
force-pushed
the
fixmultiapplynamespace
branch
from
4308221
to
5e711c0
Compare
|
Filed as internal issue #USD-9691 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The current implementation of
usdGenSchemaassumes thatpropertyNamespacePrefixused in multiple apply schemas is a valid identifier and it can be used as a token name directly. This prevents property namespaces from containing the otherwise valid:.This PR changes
propertyNamespacePrefixto be a dataclass that stores both the prefix value a valid token name that can be threaded through the schema generation process.With this change, a library's public static tokens can be used directly and there's no need for the private
_schemaTokensinternal to the class anymore.Fixes Issue(s)