Disable BOOST_UNORDERED_HAVE_PIECEWISE_CONSTRUCT for MacOS builds #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-9207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
When building with Boost 1.82 or prior on macOS with clang 15 or higher, Boost will fail to compile due to the missing
std::piecewise_constructconstant.std::piecewise_construct_t is an empty class tag type used to disambiguate between different functions that take two tuple arguments, and is present. std::piecewise_construct is a constant instant of it that doesn't seem to exist.
Since this is just a sentinal type, boost provides falling back to its own implementation. In theory this patch doesn't need to be platform specific, but for now I've set it to macOS only.