Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::intrusive_ptr with TfDelegatedCountPtr in pcp #2917

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

nvmkuruc
Copy link
Collaborator

Description of Change(s)

(Depends on #2891)

#2891 provided a TfDelegatedCountPtr to support custom bookkeeping. This replaces the usage of boost::intrusive_ptr with TfDelegatedCountPtr in PcpMapExpression. As TfDelegatedCountPtr doesn't support implicit conversion from raw pointers, construction with explicit dispatch tags are now used.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-9204

@nvmkuruc nvmkuruc changed the title Replace boost::intrusive_ptr with TfDelegatedCountPtr Replace boost::intrusive_ptr with TfDelegatedCountPtr in pcp Jan 26, 2024
@nvmkuruc nvmkuruc force-pushed the pcpintrusiveptr branch 3 times, most recently from c63d78b to 402d6a6 Compare February 8, 2024 20:50
@nvmkuruc nvmkuruc force-pushed the pcpintrusiveptr branch 5 times, most recently from 84cdbc9 to 4fb047b Compare February 12, 2024 16:15
@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@pixar-oss pixar-oss merged commit d801e41 into PixarAnimationStudios:dev Mar 28, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants