Replace boost::intrusive_ptr with TfDelegatedCountPtr for Sdf_PathNode
#2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
force-pushed
the
sdfpathintrusiveptr
branch
from
86e117e
to
bd56048
Compare
|
Filed as internal issue #USD-9125 |
nvmkuruc
force-pushed
the
sdfpathintrusiveptr
branch
from
bd56048
to
30e06b0
Compare
nvmkuruc
changed the title
boost::intrusive_ptr with TfIntrusiveTrackingPtr for Sdf_PathNodeboost::intrusive_ptr with TfDelegatedCountPtr for Sdf_PathNode
nvmkuruc
force-pushed
the
sdfpathintrusiveptr
branch
6 times, most recently
from
9df359f
to
a034e6b
Compare
nvmkuruc
force-pushed
the
sdfpathintrusiveptr
branch
5 times, most recently
from
3401433
to
ae26c54
Compare
nvmkuruc
force-pushed
the
sdfpathintrusiveptr
branch
from
ae26c54
to
a833a57
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
It looks like this got merged as a90aee2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
(Depends on #2891)
#2891 provided a
TfDelegatedCountPtrto support custom bookkeeping. This replaces the usage ofboost::intrusive_ptrwithTfDelegatedCountPtrinSdf_PathNode. AsTfDelegatedCountPtrdoesn't support implicit conversion from raw pointers, construction with explicit dispatch tags are now used.Fixes Issue(s)