Using get value producing attrs when checking texture assets in NormalMapTextureChecker #2885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
The change modifies
NormalMapTextureChecker
to use GetValueProducingAttributes instead of querying the value of the asset parameters on the texture. This way, the NormalMapTextureChecker works better with material networks that expose asset parameters on the Material and connect them to shader parameters.Questions:
@asluk
Fixes Issue(s)
No issue was created.