Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for UTF-8 Character Class Processing #2830

Merged

Conversation

erslavin
Copy link
Contributor

@erslavin erslavin commented Nov 27, 2023

Description of Change(s)

  • Added UTF-8 utility functions to Tf to determine whether
    a code point is in the XID_Start / XID_Continue character classes
  • Added static data for holding code point flags for XID_Start /
    XID_Continue
  • Added tests for XID_Start / XID_Continue code point validity
  • Added pre-processing script to generate character class ranges
    for XID_Start / XID_Continue from source DerivedCoreProperties.txt

Fixes Issue(s)

  • #USD-8702
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@erslavin
Copy link
Contributor Author

This PR replaces #2687 (which I closed)
This PR is stacked on top of #2821

@erslavin erslavin force-pushed the utf8_character_class branch 2 times, most recently from 1eda852 to a8a57c4 Compare November 28, 2023 18:35
@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8999

@erslavin erslavin force-pushed the utf8_character_class branch 2 times, most recently from 68283ab to 7640524 Compare December 6, 2023 22:45
- Added UTF-8 utility functions to Tf to determine whether
  a code point is in the XID_Start / XID_Continue character classes
- Added static data for holding code point flags for XID_Start /
  XID_Continue
- Added tests for XID_Start / XID_Continue code point validity
- Added pre-processing script to generate character class ranges
  for XID_Start / XID_Continue from source DerivedCoreProperties.txt
@pixar-oss pixar-oss merged commit c4acf38 into PixarAnimationStudios:dev Dec 11, 2023
5 checks passed
@sunyab sunyab added the usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal label Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
usd-utf8-identifiers Issues/PRs for Unicode Identifiers in USD proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants