Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix absolute path to GL libraries in pxrConfig.cmake #2827

Merged

Conversation

pmolodo
Copy link
Contributor

@pmolodo pmolodo commented Nov 22, 2023

Description of Change(s)

The absolute path to GL makes pxrConfig.cmake non-portable.

Fixes Issue(s)

  • can't use pxrConfig.cmake on computers where location of GL library differs.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8982

@pmolodo
Copy link
Contributor Author

pmolodo commented Mar 8, 2024

I've confirmed that an absolute path sneaks in on Linux (tested on Ubuntu 22.04) - tried on Windows, and apparently it's not an issue there, for whatever reason.

Unsure of behavior on MacOS...

@tallytalwar
Copy link
Contributor

tallytalwar commented Jun 18, 2024

On MacOS I think "OPENGL_gl_LIBRARY" gets substituted by "-framework OpenGL" explicitly... #2772, but I think like you said linking to "OpenGL::GL" target should also work on MacOS.

Also will go ahead and apply the same fix for pxr/imaging/glf/CMakeLists.txt

@pmolodo
Copy link
Contributor Author

pmolodo commented Jun 25, 2024

Actually - now that the Metal storm delegate exists, does MacOS even use / link to OpenGL anymore?

@tallytalwar
Copy link
Contributor

Hi @pmolodo , I confirmed with David and our imaging tests still depend on GL (via garch and glf) even on macOS. So I believe we still need this. The change is checked in internally and will be available on next dev push.

@pmolodo
Copy link
Contributor Author

pmolodo commented Jun 28, 2024

Awesome, good to hear!

@pixar-oss pixar-oss merged commit f81b17f into PixarAnimationStudios:dev Jun 28, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants