[usdShade] Doc change only- Apply MaterialBindingAPI in Bind() example #2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops nice find. I thought I covered it extensively :D. |
tallytalwar
reviewed
Oct 5, 2023
| @@ -917,8 +917,8 @@ class UsdShadeMaterialBindingAPI : public UsdAPISchemaBase | |||
| /// "metalSubset", metalFaces); | |||
| /// | |||
| /// // Bind materials to the created geom-subsets. | |||
| /// UsdShadeMaterialBindingAPI(pasticSubset.GetPrim()).Bind(plastic) | |||
| /// UsdShadeMaterialBindingAPI(metalSubset.GetPrim()).Bind(metal) | |||
| /// UsdShadeMaterialBindingAPI::Apply(pasticSubset.GetPrim()).Bind(plastic) | |||
There was a problem hiding this comment.
While you are here @asluk, can you also fix the typo here? s/pasticSubset/plasticSubset/
There was a problem hiding this comment.
Also on line 913 above, there is no concept as UsdGeomMaterialBindingAPI, it should be UsdShadeMaterialBindingAPI, probably also a typo.
asluk
force-pushed
the
tweak-usdshadematbind-example
branch
from
e2624dd
to
65b8b73
Compare
asluk
force-pushed
the
tweak-usdshadematbind-example
branch
from
65b8b73
to
498e81b
Compare
|
Filed as internal issue #USD-8817 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://groups.google.com/g/usd-interest/c/auBpX7xCQSQ/m/iUeFlJrSAQAJ