Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCH Location did not take into account the build configuration #2698

Merged
merged 1 commit into from
May 17, 2024

Conversation

aaye
Copy link

@aaye aaye commented Sep 16, 2023

Description of Change(s)

  • Quick change, added the build type to the absolute path used to store the PCH result.

Fixes Issue(s)

  • Debug/Release PCH files were over-writing each other causing linker issues.
  • I have verified that all unit tests pass with the proposed changes
  • [x ] I have submitted a signed Contributor License Agreement

@aaye aaye changed the base branch from release to dev September 16, 2023 02:38
@jesschimein
Copy link

Filed as internal issue #USD-8714

@pixar-oss pixar-oss merged commit 07353e4 into PixarAnimationStudios:dev May 17, 2024
36 checks passed
@seando-adsk
Copy link
Contributor

I am getting a compiler error when trying to build USD v24.08 on Windows using VS2022 that is due to this change. When I revert this change it compiles without error.

[316/4275] Building CXX object pxr\base\arch\CMakeFiles\arch.dir\pch.cpp.obj
FAILED: pxr/base/arch/CMakeFiles/arch.dir/pch.cpp.obj
C:\PROGRA~1\MIB055~1\2022\PROFES~1\VC\Tools\MSVC\1440~1.338\bin\Hostx64\x64\cl.exe  /nologo /TP -DARCH_EXPORTS=1 -DBOOST_ALL_DYN_LINK -DBOOST_ALL_NO_LIB -DBOOST_PYTHON_NO_PY_SIGNATURES -DGLX_GLXEXT_PROTOTYPES -DGL_GLEXT_PROTOTYPES -DMFB_ALT_PACKAGE_NAME=arch -DMFB_PACKAGE_MODULE=Arch -DMFB_PACKAGE_NAME=arch -DNOMINMAX -DOPENEXR_DLL -DPXR_BUILD_LOCATION=usd -DPXR_GL_SUPPORT_ENABLED -DPXR_MATERIALX_SUPPORT_ENABLED -DPXR_OIIO_PLUGIN_ENABLED -DPXR_PLUGIN_BUILD_LOCATION=../plugin/usd -DTBB_SUPPRESS_DEPRECATED_MESSAGES=1 -DWIN32_LEAN_AND_MEAN -DYY_NO_UNISTD_H -D_CRT_SECURE_NO_WARNINGS -D_SCL_SECURE_NO_WARNINGS -Darch_EXPORTS -IT:\ecg-usd-build\v24.08\build\RelWithDebInfo\build\usd\include /EHsc /Zc:rvalueCast /Zc:strictStrings /Zc:inline- /W3 /bigobj /Zi /MP /Gm- /wd4003 /wd4244 /wd4305 /wd4267 /wd4506 /wd4091 /wd4273 /wd4180 /wd4334 /Zm150 /MD /Zi /O2 /Ob1 /DNDEBUG -std:c++17 /Yc"pxr/base/arch/pch.h" /FI"pxr/base/arch/pch.h" /Fp"T:/ecg-usd-build/v24.08/build/RelWithDebInfo/build/usd/include/pxr/base/arch/RelWithDebInfo/pch.pch" /showIncludes /Fopxr\base\arch\CMakeFiles\arch.dir\pch.cpp.obj /Fdpxr\base\arch\CMakeFiles\arch.dir\ /FS -c T:\ecg-usd-build\v24.08\build\RelWithDebInfo\build\usd\pxr\base\arch\pch.cpp
c1xx: fatal error C1083: Cannot open compiler intermediate file: 'T:/ecg-usd-build/v24.08/build/RelWithDebInfo/build/usd/include/pxr/base/arch/RelWithDebInfo/pch.pch': No such file or directory

@aaye
Copy link
Author

aaye commented Aug 16, 2024 via email

@seando-adsk
Copy link
Contributor

No rush. I have reverted the change locally and thus was able to build 24.08. Enjoy your vacation.

Thanks,
Sean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants