Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DLL export import mismatch #2691

Merged
merged 1 commit into from
May 17, 2024

Conversation

aaye
Copy link

@aaye aaye commented Sep 14, 2023

Description of Change(s)

  • Fix some API tagging so that source and header have matching dll import export states.

Fixes Issue(s)

  • Fix compiler warnings.
  • I have verified that all unit tests pass with the proposed changes
  • [ x] I have submitted a signed Contributor License Agreement

@aaye aaye changed the base branch from release to dev September 14, 2023 00:04
@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8706

@aaye aaye force-pushed the dev_pr_dll_importexport branch 2 times, most recently from f8b0be4 to 2e8fb8b Compare September 14, 2023 21:50
@aaye aaye force-pushed the dev_pr_dll_importexport branch from 2e8fb8b to e89c7b5 Compare September 15, 2023 11:05
@spiffmon
Copy link
Member

spiffmon commented Apr 8, 2024

Would you mind updating/resolving this, @aaye ? All but the usdSkelImaging and usdVolImaging have been resolved, but we'd love to get your fixes for those two!

@aaye
Copy link
Author

aaye commented Apr 12, 2024

Happy to but it will take me a bit. Have not updated/pulled down the repo for a few months.

@tcauchois
Copy link
Contributor

Hey Andrew,

I've merged the remaining fixes from your PR, and will check it in early next week if CI is clean (which it should be). No need for you to do the merge.

Thanks!
Tom

@pixar-oss pixar-oss merged commit 2d035b5 into PixarAnimationStudios:dev May 17, 2024
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants