Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::unordered_map with robin_map in usdImaging/usdImaging #2681

Closed

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Sep 12, 2023

Description of Change(s)

This continues the replacement of boost::unordered_map in usdImaging and cleans up some headers and usage of boost::hash in favor TfHash. Performance testing suggested a performance impact using std::unordered_map so robin_map is used instead.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8695

@nvmkuruc nvmkuruc changed the title Replace boost::hash with TfHash in usdImaging/usdImaging Replace boost::unordered_map with std::unordered_map in usdImaging/usdImaging Sep 19, 2023
@nvmkuruc nvmkuruc changed the title Replace boost::unordered_map with std::unordered_map in usdImaging/usdImaging Replace boost::unordered_map with robin_map in usdImaging/usdImaging Oct 23, 2023
pixar-oss added a commit that referenced this pull request Nov 6, 2023
Replace `boost::unordered_map` with `robin_map` in `usdImaging/usdImaging`

(Internal change: 2302428)
@nvmkuruc
Copy link
Collaborator Author

nvmkuruc commented Dec 5, 2023

@sunyab @jesschimein @tallytalwar It looks like this commit got merged, should this PR be closed?

@tallytalwar
Copy link
Contributor

Closing this, as noted by @nvmkuruc the commits from this PR were merged and available in the dev branch under commit: 7514fbe

@tallytalwar tallytalwar closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants