Replace boost::unordered_map with robin_map in usdImaging/usdImaging
#2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8695 |
nvmkuruc
force-pushed
the
primvarcachehash
branch
from
f654b6f
to
d1e47b9
Compare
nvmkuruc
changed the title
boost::hash with TfHash in usdImaging/usdImagingboost::unordered_map with std::unordered_map in usdImaging/usdImaging
nvmkuruc
force-pushed
the
primvarcachehash
branch
from
d1e47b9
to
6b0c04e
Compare
nvmkuruc
force-pushed
the
primvarcachehash
branch
from
6b0c04e
to
d90bb9e
Compare
nvmkuruc
changed the title
boost::unordered_map with std::unordered_map in usdImaging/usdImagingboost::unordered_map with robin_map in usdImaging/usdImaging
nvmkuruc
force-pushed
the
primvarcachehash
branch
from
d90bb9e
to
43632cb
Compare
nvmkuruc
force-pushed
the
primvarcachehash
branch
from
43632cb
to
ef5c056
Compare
pixar-oss
added a commit
that referenced
this pull request
Nov 6, 2023
Replace `boost::unordered_map` with `robin_map` in `usdImaging/usdImaging` (Internal change: 2302428)
|
@sunyab @jesschimein @tallytalwar It looks like this commit got merged, should this PR be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This continues the replacement of
boost::unordered_mapinusdImagingand cleans up some headers and usage ofboost::hashin favorTfHash. Performance testing suggested a performance impact usingstd::unordered_mapsorobin_mapis used instead.Fixes Issue(s)