Support for UTF-8 chars in TfDictionaryLessThan #2673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
reviewed
Sep 11, 2023
| TF_AXIOM(!DictLessThan("𓀊", "A")); | ||
| TF_AXIOM(!DictLessThan("∫", "=")); | ||
| TF_AXIOM(DictLessThan("༢", "6")); | ||
| TF_AXIOM(DictLessThan("༢", "༨")); |
There was a problem hiding this comment.
Is it possible to include _ in these tests since it's handled specially?
There was a problem hiding this comment.
yep, added a few more that include _
erslavin
force-pushed
the
utf8
branch
2 times, most recently
from
6440ecd
to
37b9584
Compare
|
Filed as internal issue #USD-8687 |
2 tasks
- Added support for UTF-8 characters in sorting algorithm - Added additional tests with strings containing UTF-8 characters
This was referenced Dec 9, 2023
sunyab
added
the
usd-utf8-identifiers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Fixes Issue(s)