hdx: update color correction task to support building against OpenColorIO 2.3.0 #2651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orIO 2.3.0 OpenColorIO version 2.3.0 introduced a TextureDimensions enum parameter to GpuShaderCreator::getTexture(). This directly determines the dimensions (1D vs 2D) of the texture rather than inferring it from whether the height of the texture is one. More detail about this change is available from the OpenColorIO commit here: AcademySoftwareFoundation/OpenColorIO@929d536
|
Filed as internal issue #USD-8657 |
|
Hi, does this issue have some progress? This is blocking us in Fedora minizip-ng transition change [1] Thank you for the answer. [1] https://fedoraproject.org/wiki/Changes/MinizipNGTransition |
|
We're planning to land this change for our next release, 24.02. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenColorIO version 2.3.0 introduced a
TextureDimensionsenum parameter toGpuShaderCreator::getTexture(). This directly determines the dimensions (1D vs 2D) of the texture rather than inferring it from whether the height of the texture is one.More detail about this change is available from the OpenColorIO commit here:
AcademySoftwareFoundation/OpenColorIO@929d536