[tf] fix for python dll loading order #2595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tf uses WindowsImportWrapper to add directories on the PATH to the list of allowable directories to find .dll files, so python modules relying on finding .dlls on the PATH will continue to work. However, it seems that os.add_dll_directory works in a "most recently added wins" manner, so we need to reverse the order that we call it for entries on the PATH.
|
Filed as internal issue #USD-8593 |
|
Hi - if this PR seems a bit bulky, the vast majority is an added test for correct PATH ordering, which was a bit tricky to get right. The functional change is a single line (really, a single additional call to I'm ok with dropping the test if the test seems too bulky... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Tf uses
WindowsImportWrapperto add directories on thePATHto the list of allowable directories to find .dll files, so python modules relying on finding .dlls on thePATHwill continue to work.However, it seems that
os.add_dll_directoryworks in a "most recently added wins" manner, so we need to reverse the order that we call it for entries on thePATH.Fixes Issue(s)