Autodesk: Fix for MSAA configuration on macOS #2561
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
Here's the issue:
Most of our apps use an MSAA configuration, and on macOS we are getting the error:
the sample count (4) does not match the renderPipelineState's sample count (1).
The issue is that the PSO does not have the correct (MSAA) sample count for the target.
I tracked this down to some code in pxr/imaging/hdSt/pipelineDrawBatch.cpp, in _GetDrawPipeline() where the correct state configured by a call to InitGraphicsPipelineDesc() is later overwritten. The fix here simply moves the call to InitGraphicsPipelineDesc() a few rows down, after the hardcoded initialization.
Fixes Issue(s)