Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Fix for MSAA configuration on macOS #2561

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

Here's the issue:

Most of our apps use an MSAA configuration, and on macOS we are getting the error:

  • [MTLDebugRenderCommandEncoder setRenderPipelineState]:1598: failed assertion 'Set Render Pipeline State Validation
    the sample count (4) does not match the renderPipelineState's sample count (1).

The issue is that the PSO does not have the correct (MSAA) sample count for the target.

I tracked this down to some code in pxr/imaging/hdSt/pipelineDrawBatch.cpp, in _GetDrawPipeline() where the correct state configured by a call to InitGraphicsPipelineDesc() is later overwritten. The fix here simply moves the call to InitGraphicsPipelineDesc() a few rows down, after the hardcoded initialization.

Fixes Issue(s)

  • N/A
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8550

@pixar-oss pixar-oss closed this in 456b705 Apr 19, 2024
@erikaharrison-adsk erikaharrison-adsk deleted the adsk/bugfix/msaafix branch October 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants