Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost::iterator_facade with explicit implementation for SdfMapProxy #2549

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jul 24, 2023

Description of Change(s)

  • Replace iterator_facade with explicit implementation for SdfMapProxy
  • Uses type traits / SFINAE to provide two implementations of operator-> depending on whether the reference type is a true reference and can be safely converted to a pointer or if it's a proxy type and needs a pointer proxy to manage lifetime. Added a comment to recommend deprecating usage of operator-> for C++20 to avoid this complexity.

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link

Filed as internal issue #USD-8522

@pixar-oss pixar-oss merged commit 26e934b into PixarAnimationStudios:dev Jul 27, 2023
34 of 36 checks passed
@nvmkuruc nvmkuruc deleted the sdfmapproxyfacade branch December 29, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants