Replace boost::iterator_facade with explicit iterator implementation for SdfListProxy
#2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filed as internal issue #USD-8521 |
nvmkuruc
force-pushed
the
sdflistproxyfacade
branch
from
6174b7c
to
ba165e7
Compare
crevilla
reviewed
Jul 24, 2023
|
|
||
| _Iterator(Owner owner, size_t index) : _owner(owner), _index(index) | ||
| { | ||
| // Do nothing | ||
| } | ||
|
|
||
| reference operator*() const { return dereference(); } |
There was a problem hiding this comment.
I'm confused as to why this -> returns the address directly when you define pointer = _PtrProxy and static_assert that value type of reference is not an lvalue. My expectation is that your assert would mean we always return the _PtrProxy or that we want a conditional type here like you did SdfMapEditProxy
There was a problem hiding this comment.
You're right! That was an error. Thanks.
nvmkuruc
force-pushed
the
sdflistproxyfacade
branch
from
ba165e7
to
3ac6a16
Compare
…n for `SdfListProxy`
nvmkuruc
force-pushed
the
sdflistproxyfacade
branch
from
3ac6a16
to
132dff9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
iterator_facadewith explicit implementation forSdfListProxy's iteratorFixes Issue(s)
boost::iterator_facadeusage with fully specified iterator classes #2305