Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded boost dependencies from python bindings #2524

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nvmkuruc
Copy link
Collaborator

@nvmkuruc nvmkuruc commented Jul 5, 2023

Description of Change(s)

Several usages of boost in the python bindings can be easily removed.

  • Remove unused header references to boost/functional/hash.hpp
  • Introduce a simple pair and range-like struct for iterators to remove boost::begin and boost::end in favor of std::begin and std::end
  • Replace boost::lexical_cast with TfStringify

Fixes Issue(s)

N/A

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Contributor

Filed as internal issue #USD-8480

@@ -54,6 +50,23 @@ PXR_NAMESPACE_USING_DIRECTIVE

namespace {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this would be simpler if we just change the PluginNames function to no longer be templated and just take two const PlugPluginPtrVector::iterator & parameters instead for begin and end. This especially given it's only called in two places.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@pixar-oss pixar-oss merged commit 51da69a into PixarAnimationStudios:dev Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants