Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validating UsdCollectionAPI before accessing in UsdShadeMaterialBindingAPI::ComputeBoundMaterial #2501

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

sirpalee
Copy link
Contributor

@sirpalee sirpalee commented Jun 26, 2023

Description of Change(s)

Validating UsdCollectionAPI before accessing in UsdShadeMaterialBindingAPI::ComputeBoundMaterial.

This is a quick proposal to fix #2500 , but I'm unsure if this is the right place to do so. I.e. should we validate collections earlier, like in UsdShadeMaterialBindingAPI::_GetCollectionBindings or a similar place?

Fixes Issue(s)

  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-8440

@pixar-oss pixar-oss merged commit 7378558 into PixarAnimationStudios:dev Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants