usdBakeMtlx, usdrecord: skip building usdImaging tools if GPU and/or OpenGL are unavailable #2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usdrecord has usdAppUtils as a dependency, which is only built when GPU support is enabled.
usdBakeMtlx has MaterialX's MaterialXRenderGlsl library as a dependency, which makes use of OpenGL. If OpenGL support is unavailable or disabled for the USD build, we should skip building usdBakeMtlx since MaterialXRenderGlsl may not be available.
|
Filed as internal issue #USD-8399 |
mattyjams
deleted the
pr/skip_building_usdImaging_tools_without_GPU_or_OpenGL
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two issues when building USD with
PXR_BUILD_USD_IMAGINGenabled butPXR_ENABLE_GPU_SUPPORTand/orPXR_ENABLE_GL_SUPPORTdisabled.The build of
usdAppUtilsis gated onPXR_BUILD_GPU_SUPPORTbeing enabled, but there was no such check forusdrecord, so the build would be aborted when CMake goes to buildusdrecordbut discovers the dependency is missing.The
usdBakeMtlxchange might be slightly more contentious, but in environments where OpenGL is not supported, it's likely that building MaterialX will yield an installation that is missing theMaterialXRenderGlsllibrary. Attempting to then build USD in that environment against such an installation of MaterialX withPXR_ENABLE_GL_SUPPORTdisabled would be aborted when CMake goes to buildusdBakeMtlxbut discovers the dependency is missing.