Report the path of the invalid spec (not the inducing spec) in SdfCopySpec
#2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvmkuruc
changed the title
SdfCopySpec
|
Filed as internal issue #USD-8354 |
pixar-oss
added a commit
that referenced
this pull request
Jul 3, 2023
Report the path of the invalid spec (not the inducing spec) in `SdfCopySpec` (Internal change: 2282874)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
SdfCopySpeciterates over child specs when copying. If any of those specs is invalid (GetSpecType() == SdfSpecTypeUnknown), a coding error is reported. However, the error message reports the path to the inducing spec (the source path argument toSdfCopySpec) as invalid when a child is invalid.This PR fixes the error message so that the right spec is reported as being invalid.
Fixes Issue(s)