APPLE: Buffer binding null pointer checks #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creijon
force-pushed
the
jon/dev/step_func_null_pointer_check
branch
3 times, most recently
from
2bccb86
to
fc642bb
Compare
creijon
changed the title
|
Filed as internal issue #USD-8265 |
creijon
force-pushed
the
jon/dev/step_func_null_pointer_check
branch
from
fc642bb
to
383ad76
Compare
creijon
force-pushed
the
jon/dev/step_func_null_pointer_check
branch
from
383ad76
to
dd39326
Compare
creijon
force-pushed
the
jon/dev/step_func_null_pointer_check
branch
from
dd39326
to
44b6643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
If an empty USD file was loaded, a null buffer would be passed into the step function and indirect command buffer bindings, causing a segfault. This protects against it.
Fixes Issue(s)