Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPLE: Add an option to turn off dome light background in usdrecord #2352

Merged

Conversation

creijon
Copy link
Contributor

@creijon creijon commented Mar 22, 2023

Description of Change(s)

Add an option to turn off dome light background in usdrecord

Fixes Issue(s)

  • For creating cards, it is helpful to remove the dome light background.
  • I have verified that all unit tests pass with the proposed changes
  • I have submitted a signed Contributor License Agreement

@tallytalwar
Copy link
Contributor

Filed as internal issue #USD-8139

@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch from e95e053 to 63f9f42 Compare April 4, 2023 07:21
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch 2 times, most recently from 7fedec7 to cb7100b Compare April 16, 2023 07:35
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch from cb7100b to 1a184bd Compare April 26, 2023 11:18
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch 2 times, most recently from b165150 to 8bd5b4d Compare May 13, 2023 05:44
@creijon creijon changed the title Add an option to turn off dome light background in usdrecord APPLE: Add an option to turn off dome light background in usdrecord May 16, 2023
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch from 8bd5b4d to a979004 Compare May 21, 2023 15:43
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch 2 times, most recently from 726329d to d60c3b9 Compare June 12, 2023 13:30
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch from d60c3b9 to 1049d8c Compare March 12, 2024 19:22
@creijon creijon force-pushed the jon/dev/usdrecord_domelight_flag branch from 1049d8c to 531d1c9 Compare April 4, 2024 08:21
@jesschimein
Copy link
Contributor

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

beersandrew added a commit to beersandrew/assets that referenced this pull request Apr 24, 2024
- used: PixarAnimationStudios/OpenUSD#2352 to execute this.

- includes a change to the script to not crash on when timeCodesPerSecond is 0.0
@pixar-oss pixar-oss merged commit 2ae8374 into PixarAnimationStudios:dev Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants